Fix redundant leading apostrophe in TS1344 diagnostic message#63341
Merged
RyanCavanaugh merged 3 commits intomainfrom Apr 2, 2026
Merged
Fix redundant leading apostrophe in TS1344 diagnostic message#63341RyanCavanaugh merged 3 commits intomainfrom
RyanCavanaugh merged 3 commits intomainfrom
Conversation
Agent-Logs-Url: https://github.com/microsoft/TypeScript/sessions/2d7e755d-ab2c-4d9e-b4a1-065611ff2edb Co-authored-by: RyanCavanaugh <6685088+RyanCavanaugh@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix redundant leading apostrophe in ts1344 diagnostic
Fix redundant leading apostrophe in TS1344 diagnostic message
Apr 2, 2026
RyanCavanaugh
requested changes
Apr 2, 2026
Member
RyanCavanaugh
left a comment
RyanCavanaugh
left a comment
There was a problem hiding this comment.
@copilot revert all changes under /loc and store a memory that you are not allowed to edit this as part of a PR
Agent-Logs-Url: https://github.com/microsoft/TypeScript/sessions/a744264b-2dc7-4e98-ad24-9d62ce1fd801 Co-authored-by: RyanCavanaugh <6685088+RyanCavanaugh@users.noreply.github.com>
Contributor
Author
RyanCavanaugh
approved these changes
Apr 2, 2026
jakebailey
approved these changes
Apr 2, 2026
Member
jakebailey
left a comment
jakebailey
left a comment
There was a problem hiding this comment.
Wow, this has been here since probably forever
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes the user-facing text for diagnostic TS1344 by removing an unintended leading apostrophe that was embedded in the compiler’s diagnostic message source, and updates affected test baselines accordingly.
Changes:
- Update
src/compiler/diagnosticMessages.jsonto remove the spurious leading'from the TS1344 message text. - Update reference baseline
.errors.txtfiles to match the corrected TS1344 output (no leading apostrophe).
Reviewed changes
Copilot reviewed 29 out of 29 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/compiler/diagnosticMessages.json |
Corrects the TS1344 message text by removing the unintended leading apostrophe. |
tests/baselines/reference/*.errors.txt |
Updates expected diagnostic output for TS1344 to match the corrected message text. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The TS1344 diagnostic message had a spurious leading
'baked into its key indiagnosticMessages.json, causing the error to render as:instead of:
Changes
src/compiler/diagnosticMessages.json— Remove leading'from the1344message key. The generated identifierA_label_is_not_allowed_hereis unaffected; no changes needed inbinder.tsorprogram.ts.'.